guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27123: fonts: more changes to font-build-system, one follow up commi


From: Arun Isaac
Subject: bug#27123: fonts: more changes to font-build-system, one follow up commit
Date: Mon, 29 May 2017 23:17:43 +0530

Thanks for the patches! Patches 1, 3 and 4 LGTM.

Patch 2...

> * gnu/packages/fonts.scm (font-awesome)[source]: Switch to the source on 
> github as the previous zip file
> is updated in place, resulting in a changed hash sum.

This commit message line is too long. On emacs, you can wrap it to the
next line with `fill-paragraph'.

The contents of the zip archive are updated in place without changing
the version number? Is that what you mean by "in place"?

Should we treat this as a one-time accident by upstream? Or have they
made a habit out of this?

IMO, we should forgive them this one time, and if they do this again,
then we can move to their github release archive. WDYT?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]