guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#26339: [PATCH v4 4/7] scripts: system: Adapt "reconfigure" to new bo


From: Ludovic Courtès
Subject: bug#26339: [PATCH v4 4/7] scripts: system: Adapt "reconfigure" to new bootloader API.
Date: Sun, 14 May 2017 15:31:20 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Mathieu Othacehe <address@hidden> skribis:

> * guix/scripts/system.scm (install-grub*): Rename to install-bootloader. Use
>   keys to pass arguments. Pass a new argument, "installer.drv" which is
>   a script in store dealing with bootloader-specific install actions.
>   Also call "install-boot-config" to install the bootloader config file.
 ^^
Extra space.

> (install-bootloader-derivation): New procedure. It returns a derivation that
> builds a file containing "install-procedure" gexp.
> (perform-action): Build install-proc derivation and call install-bootloader
> with the resulting file. Stop adding GRUB to PATH as bootloaders are called in
> install-proc with direct store paths.

[...]

> +(define* (install-bootloader installer.drv

Please avoid dots in identifiers.

Otherwise LGTM!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]