[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26803: [PATCH 15/36] gnu: Add java-commons-io.
From: |
Ricardo Wurmus |
Subject: |
bug#26803: [PATCH 15/36] gnu: Add java-commons-io. |
Date: |
Wed, 10 May 2017 16:10:39 +0200 |
User-agent: |
mu4e 0.9.18; emacs 25.2.1 |
Roel Janssen <address@hidden> writes:
> Ricardo Wurmus writes:
>
>> From: Hartmut Goebel <address@hidden>
>>
>> * gnu/packages/java.scm (java-commons-io): New variable.
>>
>> Co-authored-by: Ricardo Wurmus <address@hidden>
>> ---
[…]
>> + (arguments
>> + `(#:test-target "test"
>> + #:phases
>> + (modify-phases %standard-phases
>> + (add-after 'unpack 'symlink-junit.jar
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + ;; TODO: don't do this; use make-flags
>> + ;; The existence of this file is taken as indicator whether
>> test
>> + ;; dependencies will to be downloaded.
>> + (let ((junit (assoc-ref inputs "java-junit"))
>> + (junit-version "4.12")) ; from build.xml
>> + (mkdir-p "lib")
>> + (symlink (string-append junit "/share/java/junit.jar")
>> + (string-append "lib/junit-" junit-version ".jar"))
>> + #t)))
>
> I'm not sure how the result of the code here could be achieved
> using 'make-flags', so is the TODO item referring to an already-removed
> piece of code?
Oh, I forgot about this. It’s actually pretty easy to do this with
make-flags:
#:make-flags
(list (string-append "-Djunit.jar="
(assoc-ref %build-inputs "java-junit")
"/share/java/junit.jar"))
Much nicer than symlinking things!
I’ll push it with this change.
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
bug#26803: [PATCH 12/36] gnu: Add java-commons-math3., Ricardo Wurmus, 2017/05/06
bug#26803: [PATCH 19/36] gnu: Add java-commons-codec., Ricardo Wurmus, 2017/05/06
bug#26803: [PATCH 16/36] gnu: Add java-commons-lang., Ricardo Wurmus, 2017/05/06