[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26339: [PATCH v3 1/9] system: Add extlinux support.
From: |
Danny Milosavljevic |
Subject: |
bug#26339: [PATCH v3 1/9] system: Add extlinux support. |
Date: |
Sun, 7 May 2017 18:41:05 +0200 |
Hi Mathieu,
>guix/scripts/system.scm (profile-grub-entries):
>Rename system->grub-entry to system->boot-parameters and adjust accordingly.
Not really - because I did this part already :)
That part of the commit message is outdated.
> + (bootloader (let ((bootloader (bootloader-configuration-bootloader
> + (operating-system-bootloader os))))
> + (if bootloader
> + (package->derivation bootloader)
> + (return #f))))
[...]
> + (if (and bootloader? bootloader)
Hmm, is it possible to (usefully) check monadic values that way?
> + (when (and bootloader? bootloader)
Likewise.
Otherwise LGTM!
- bug#26339: [PATCH v3 0/9] Support non-grub bootloaders., Mathieu Othacehe, 2017/05/06
- bug#26339: [PATCH v3 4/9] bootloader: Stop using grub module., Mathieu Othacehe, 2017/05/06
- bug#26339: [PATCH v3 3/9] system: Add bootloader type., Mathieu Othacehe, 2017/05/06
- bug#26339: [PATCH v3 1/9] system: Add extlinux support., Mathieu Othacehe, 2017/05/06
- bug#26339: [PATCH v3 1/9] system: Add extlinux support.,
Danny Milosavljevic <=
- bug#26339: [PATCH v3 5/9] bootloader: Add device and type to bootloader-configuration record., Mathieu Othacehe, 2017/05/06
- bug#26339: [PATCH v3 6/9] scripts: system: Adapt "reconfigure" to new bootloader API., Mathieu Othacehe, 2017/05/06
- bug#26339: [PATCH v3 6/9] scripts: system: Adapt "reconfigure" to new bootloader API., Danny Milosavljevic, 2017/05/07