guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25746: python-pykka


From: Kei Kebreau
Subject: bug#25746: python-pykka
Date: Thu, 02 Mar 2017 14:16:26 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

ng0 <address@hidden> writes:

> On 17-02-19 13:02:01, Ricardo Wurmus wrote:
>> 
>> ng0 <address@hidden> writes:
>> 
>> >> > > +    (arguments
>> >> > > +     `(#:tests? #f)) ; Testsuite fails for unspecified reasons.
>> >> > 
>> >> > It would be nice to have some more details here and a FIXME, so that
>> >> > dedicated folks could fix this in the future.
>> 
>> […]
>> 
>> > I tried running the build using the git versions in the package
>> > definition, and the python tests hang forever. I stopped after 3 - 5
>> > hours:
>> […]
>> > test_base_exception_is_logged 
>> > (tests.logging_test.ConcreteActorLoggingTest.<locals>.C) ...
>> >
>> >
>> > The last one (test_base_exception_is_logged) is the one where it
>> > hangs.
>> 
>> How about disabling that one test then?
>> 
>> > Without 'mopidy' https://github.com/mopidy I don't know if these
>> > test failures are grave or just minor.
>> 
>> I don’t know how this relates to the rest of this patch.
>> 
>> > My idea is now to just use the tarball version, skip the tests
>> 
>> Using the official release is preferred, but I’d rather not skip all the
>> tests.  We rarely ever do this unless there are bootstrap issues.
>> Please try to disable just the hanging tests instead of the complete
>> test suite.
>> 
>> -- 
>> Ricardo
>> 
>> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
>> https://elephly.net
>> 
>
> I fixed it, patches are appended as git send-email is still broken since 
> 82de2655a16dcc7a8e3b992b4afd34ec32c244a6. 

Looks good! Pushed as de959250411830584366a0397367032f10c3c352 and
a80488c20481e2a86a1808b85530342cf119b424 to master.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]