bug#25843: [PATCH 1/2] gnu: Add zstd.

[Marius Bakke]

Tobias Geerinckx-Rice <address@hidden> writes:

> * gnu/packages/compression.scm (zstd): New variable.
> ---
>  gnu/packages/compression.scm | 41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>
> diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
> index 9897883..9870158 100644
> --- a/gnu/packages/compression.scm
> +++ b/gnu/packages/compression.scm
> @@ -1128,3 +1128,44 @@ or junctions, and always follows hard links.")
>                     ;; libzpaq.cpp contains a mix of public-domain and
>                     ;; expat-licenced (or ‘MIT’) code.
>                     license:expat))))
> +
> +(define-public zstd
> +  (package
> +    (name "zstd")
> +    (version "1.1.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append 
> "https://github.com/facebook/zstd/archive/v";
> +                                  version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "02mgk7cbyksfx7mq95cykghb7dya797z0n2jxr5fx9j0x0m56v0h"))
> +              (modules '((guix build utils)))
> +              (snippet
> +               ;; Remove non-free source files.
> +               '(for-each delete-file-recursively
> +                          (list
> +                           ;; Commercial use of the following is not allowed.
> +                           "examples"
> +                           "LICENSE-examples")))))

Ugh. Good catch. Note that snippets should end on a #t.

> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("autoconf" ,autoconf)))

It's not obvious to me why this package requires autoconf. Could you add
an explaining comment?

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure))           ; no configure script
> +       #:make-flags
> +       (list "CC=gcc"
> +             (string-append "PREFIX=" (assoc-ref %outputs "out")))
> +       #:test-target "test"))
> +    (home-page "http://zstd.net/";)
> +    (synopsis "Zstandard real-time compression algorithm")
> +    (description "Zstandard (@command{zstd}) is a lossless compression 
> algorithm
> +that combines very fast operation with a compression ratio comparable to 
> that of
> +zlib.  In most scenarios, both compression and decompression can be 
> performed in
> +‘real time’.  The compressor can be configured to provide the most suitable
> +trade-off between compression ratio and speed, without affecting 
> decompression
> +speed.")
> +    (license license:bsd-3)))

Some of the files under "zlibWrapper" carry the zlib license; I also
found BSD-2 in "zstdgrep" and the bundled "xxhash" (but did not do a
complete audit).

Otherwise LGTM, thanks! Now I can try unbundling it from my WIP Ceph
package! :)

> -- 
> 2.9.3

Whoa, you really don't like using software from Guix, do you ;)

signature.asc
Description: PGP signature