[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25787: [PATCH 2/6] gnu: Add libechonest.
From: |
Marius Bakke |
Subject: |
bug#25787: [PATCH 2/6] gnu: Add libechonest. |
Date: |
Wed, 22 Feb 2017 17:03:57 +0100 |
User-agent: |
Notmuch/0.23.5 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu) |
Pierre Langlois <address@hidden> writes:
> * gnu/packages/music.scm (libechonest): New variable.
> ---
> gnu/packages/music.scm | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index ce874ac43..84c537d86 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -9,6 +9,7 @@
> ;;; Copyright © 2016 John J. Foerch <address@hidden>
> ;;; Copyright © 2016 Alex Griffin <address@hidden>
> ;;; Copyright © 2017 ng0 <address@hidden>
> +;;; Copyright © 2017 Pierre Langlois <address@hidden>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -2050,6 +2051,32 @@ detailed track info including timbre, pitch, rhythm
> and loudness information.
> @end enumerate\n")
> (license license:bsd-3)))
>
> +(define-public libechonest
> + (package
> + (name "libechonest")
> + (version "2.3.1")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "git://anongit.kde.org/libechonest.git")
> + (commit "6895a77a46c9bd4e009ae08515bd91dc3cfbf548")))
> + (file-name (string-append name "-" version "-checkout"))
Could you add a comment explaining why we can't use a normal release
tarball here?
> + (sha256
> + (base32
> + "0xbavf9f355dl1d3qv59x4ryypqrdanh9xdvw2d0q66l008crdkq"))))
> + (build-system cmake-build-system)
> + (arguments
> + '(#:tests? #f)) ; Tests require Internet access
> + (inputs
> + `(("qt" ,qt-4)
> + ("qjson" ,qjson)))
Same comment here about using Qt5 by default (if possible), and adding
qt4 variants where necessary.
> + (home-page
> "https://projects.kde.org/projects/playground/libs/libechonest")
> + (synopsis "C++/Qt classes to interface with The Echo Nest API")
> + (description "libechonest is a collection of C++/Qt classes designed to
> make
@code{libechonest} ...
> + a developer's life easy when trying to use the APIs provided by The Echo
> +Nest.")
Could you explain briefly what "The Echo Nest" is here?
> + (license license:gpl2)))
Do the sources explicitly specify "version 2 only"? Otherwise it should
probably be gpl2+. Otherwise this package LGTM.
> +
> (define-public python-pylast
> (package
> (name "python-pylast")
> --
> 2.11.1
signature.asc
Description: PGP signature
- bug#25787: [PATCH 0/6] Add Clementine music player., Pierre Langlois, 2017/02/18
- bug#25787: [PATCH 5/6] gnu: sqlite: Enable FTS3., Pierre Langlois, 2017/02/18
- bug#25787: [PATCH 1/6] gnu: Add qjson., Pierre Langlois, 2017/02/18
- bug#25787: [PATCH 2/6] gnu: Add libechonest., Pierre Langlois, 2017/02/18
- bug#25787: [PATCH 2/6] gnu: Add libechonest.,
Marius Bakke <=
- bug#25787: [PATCH 4/6] gnu: nss: Update to 3.28.1., Pierre Langlois, 2017/02/18
- bug#25787: [PATCH 3/6] gnu: Add cryptopp., Pierre Langlois, 2017/02/18
- bug#25787: [PATCH 6/6] gnu: Add Clementine., Pierre Langlois, 2017/02/18
- bug#25787: [PATCH 6/6], Thomas Danckaert, 2017/02/20
- bug#25787: [PATCH 0/6] Add Clementine music player., Marius Bakke, 2017/02/22