[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25733: [PATCH 07/18] gnu: Add python-repoze-lru.
From: |
Ricardo Wurmus |
Subject: |
bug#25733: [PATCH 07/18] gnu: Add python-repoze-lru. |
Date: |
Sat, 18 Feb 2017 13:13:44 +0100 |
User-agent: |
mu4e 0.9.18; emacs 25.1.1 |
address@hidden writes:
> From: ng0 <address@hidden>
>
> * gnu/packages/python.scm (python-repoze-lru): New variable.
> ---
> gnu/packages/python.scm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index c603d0778..fb296e712 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -2030,6 +2030,31 @@ result back.")
> (define-public python2-pytest-xdist
> (package-with-python2 python-pytest-xdist))
>
> +(define-public python-repoze-lru
> + (package
> + (name "python-repoze-lru")
> + (version "0.6")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "repoze.lru" version))
> + (sha256
> + (base32
> + "0cdx3fq67qfcdrb3h9rjjcvks2zfrgyd834indncplqnywxk4yhg"))))
> + (build-system python-build-system)
> + (home-page "http://www.repoze.org")
> + (synopsis "Tiny LRU cache implementation and decorator")
Please expand “LRU”.
> + (description
> + "Repoze integrates Zope technologies with WSGI and reusable
> Python middleware.")
Both synopsis and description could be improved. The synopsis is better
than the description. The fact that “Zope technologies” are used does
not describe the package.
> + (properties `((python2-variant . ,(delay python2-repoze-lru))))
I don’t think this is needed.
> + (license license:repoze)))
There is no such license. You could use “license:non-copyleft” here
with “http://repoze.org/license.html” as the argument.
> +
> +(define-public python2-repoze-lru
> + (let ((base (package-with-python2
> + (strip-python2-variant python-repoze-lru))))
> + (package
> + (inherit base))))
> +
This is really convoluted for no obvious gain. Why did you choose this
over:
(define-public python2-repoze-lru
(package-with-python2 python-repoze-lru))
?
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
- bug#25733: kallithea dependencies, ng0, 2017/02/14
- bug#25733: [PATCH 01/18] gnu: Add python-geventhttpclient., contact . ng0, 2017/02/14
- bug#25733: [PATCH 02/18] gnu: Add python-fastimport., contact . ng0, 2017/02/14
- bug#25733: [PATCH 04/18] gnu: Add address@hidden, contact . ng0, 2017/02/14
- bug#25733: [PATCH 07/18] gnu: Add python-repoze-lru., contact . ng0, 2017/02/14
- bug#25733: [PATCH 07/18] gnu: Add python-repoze-lru.,
Ricardo Wurmus <=
- bug#25733: [PATCH 11/18] gnu: Add python-urlobject-2.3.4., contact . ng0, 2017/02/14
- bug#25733: [PATCH 09/18] gnu: Add python-routes-1.13., contact . ng0, 2017/02/14
- bug#25733: [PATCH 17/18] gnu: Add python2-kombu-1., contact . ng0, 2017/02/14
- bug#25733: [PATCH 10/18] gnu: Add python-urlobject., contact . ng0, 2017/02/14
- bug#25733: [PATCH 13/18] gnu: Add python-markdown-2.2.1., contact . ng0, 2017/02/14
- bug#25733: [PATCH 14/18] gnu: Add python2-babel-1.3., contact . ng0, 2017/02/14