[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adding content-addressed URLs to

From: Ludovic Courtès
Subject: Re: Adding content-addressed URLs to
Date: Tue, 25 Apr 2023 14:40:22 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)


Simon Tournier <> skribis:

> PS: On a side note, building sources.json fails since ~1 month.
> $ guix repl -- build-package-metadata.scm /tmp/
> guix repl: package metadata will be written to '/tmp/'
> Backtrace:
> [...]
> In procedure %origin-patches-real: Wrong type argument: #<<computed-file> 
> name: "ruby-sorbet-runtime-0.5.10610.20230106174520-1fa668010-checkout" gexp: 
> #<gexp (begin (use-modules (guix build utils)) (copy-recursively 
> (string-append #<gexp-input #<origin #<<git-reference> url: 
> ""; commit: 
> "0.5.10610.20230106174520-1fa668010" recursive?: #f> #<content-hash 
> sha256:0f21dl06alxwn6xgdxyrkd58plmmsv04z2bcls9ld4cfzsrs5537> () 
> 7fa67b7f6000>:out> "/gems/sorbet-" #<gexp-input "runtime":out>) #<gexp-output 
> out>)) gnu/packages/ruby.scm:14078:5 7fa67b701c90> guile: #f options: 
> (#:local-build? #t)>

I believe this is fixed by 1df54ceab38873dfc0fd2ec27313d7d17c79c350.
(It broke the ‘source’ and ‘disarchive’ jobsets as well.)

> Somehow, it reveals 3 currently uncovered cases: computed-file appearing
> as,
>  1. ’origin’ in source field (ruby-sorbet-runtime)
>  2. ’inputs’ (racket-minimal)
>  3. ’snippet’ in origin in source field (chromium)

I think #1 and #2 are okay: we can use any file-like object there, not
just origin/package.  Of course, <origin> is meant to be the best choice
for ‘source’, and <package> the best choice for ‘inputs’.  But I think
it’s fine to occasionally resort to some other abstraction when these
two are not adequate.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]