[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/X] gnu: poetry: Fix broken dependency after dependency's ve
Tanguy Le Carrour
Re: [PATCH 0/X] gnu: poetry: Fix broken dependency after dependency's version update.
Thu, 30 Jul 2020 15:18:05 +0200
Le 07/30, Marius Bakke a écrit :
> Tanguy Le Carrour <firstname.lastname@example.org> writes:
> > Few days ago, I submitted a patch to update `python-tomlkit`. It was pushed
> > to master and, after I upgraded my packages today, I realised that `poetry`
> > (and possibly other python packages) was broken!
> > The "problem" is that Poetry depends on `tomlkit = "^0.5.11"`. This
> > translates to `>=0.5.11,<0.6.0`. And I updated `python-tomlkit` to… 0.6.0!
> > In SemVer , minor releases are supposed to "add functionality
> > in a backwards compatible manner", so this "<0.6.0" seems, IMHO, wrong.
> > But that's not the point…
> > : https://semver.org/
> > Now, I have to fix Poetry and I have 2 options:
> > - modify poetry `setup.py` and substitute `>=0.5.11,<0.7.0` to
> > `>=0.5.11,<0.6.0`;
> > - add a new `python-tomlkit-0.5` and use it in the propagated inputs.
> > Any suggestion on the one I should implement?
> I haven't looked into it, but if the tomlkit API really is compatible,
> the first suggestion sounds good to me. It would be good to notify
> upstream about the unreasonable "pinning" in that case.
Problem reported upstream:
> Otherwise the second suggestion sounds good too. There is plenty of
> precedence for both solutions in Guix and is really something that needs
> to be decided on a case-by-case basis.
I decided to implement the "quick fix":
I'll implement the `python-tomlkit-0.5` solution if upstream does not
see this as a problem.