Re: 01/03: ui: Only display link in capable terminals.

[Ludovic Courtès]

Hi,

Pierre Neidhardt <address@hidden> skribis:

> Ludovic Courtès <address@hidden> writes:
>
>> So people see less information on terminals that support hyperlinks,
>> right?
>>
>> I think there should be as much information displayed whether or not the
>> terminal supports hyperlinks.  Otherwise it can be confusing.
>> (Especially since we can’t tell whether the terminal really supports
>> hyperlinks: we don’t know whether it displays clickable links.)
>>
>> Thoughts?
>
> The file/URL was not displayed in terminals that support hyperlinks.
> This was also true before this commit.
>
> The user has to guess that they are clickable.

The user can hover over it, but VTE, Eterm, etc. make hyperlinks visible
even when you don’t hover over them.

The hyperlink is an enhancement, not a piece of information that was
intended to be displayed upfront.

>>> --- a/guix/ui.scm
>>> +++ b/guix/ui.scm
>>> @@ -1637,7 +1637,7 @@ DURATION-RELATION with the current time."
>>>      (let* ((file   (generation-file-name profile number))
>>>             (link   (if (supports-hyperlinks?)
>>>                         (cut file-hyperlink file <>)
>>> -                       identity))
>>> +                       (cut format #f (G_ "~a~%file: ~a") <> file)))
>>>             (header (format #f (link (highlight (G_ "Generation ~a\t~a")))
>>
>> I understand it’s a matter of taste, but I’m not a fan of the extra
>> line here.
>
> You mean the "~%" in "~a~%file: ~a"?
> How would you like to display it?

I would not display it at all.  I think it’s a bit of clutter that’s
best avoided.

I guess I’m suggesting a revert of this patch.

WDYT?

Ludo’.