Re: qtwenengine anybody?

[mike . rosset]

Hartmut Goebel <address@hidden> writes:

> Am 07.01.20 um 01:27 schrieb address@hidden:
>>
>>> With these changes, I think the package is ready to go.  \o/
>> This is really great work Marius I appreciate this addition. I was
>> actually just looking at this approach yesterday. 
>>
>> I've merged your two patches with one minor description addition that Hartmut
>> requested.
>
>
> Great work you've done! I'm looking forward to get this merged to
> master, so I can continue working on some more KDE packages.
>
>
>> Hartmut the merged complete diff can be found here.
>> https://gitlab.com/mike.rosset/guix/compare/master...merge-qtwebengine
>
> Fine for me.
>
> Just some super-nitpicky nitpicks:
>
>
>> +               (base32
>> +               
>> "08c60nh95m98mcqk444axs76xi6m9x0wvdxrzk9c2cxwqdbz59fa"))))
>
> Maybe move has into `base32` line
>
>
>> +             (define (third-party? file)
>> +               (if (string-contains file "third_party/")
>> +                   #t
>> +                   #f))
> The "if" could be omitted, I assume


Hello Hartmut,

I've attached a patch that resolves these suggestions. Along with
patches to fix punctuation suggested by Pierre.

Complete diff can still be found
at. https://gitlab.com/mike.rosset/guix/compare/master...merge-qtwebengine

Marius I've forgot to attach from your series in my last email. I've
attached the rest of the series for you. encase you want to git am.

0003-gnu-qtwebengine-description-field-now-notes-source-r.patch
Description: Text Data

0004-gnu-qtwebengine-simplify-snippet-field-third-party-f.patch
Description: Text Data

0005-gnu-qtwebengine-improve-punctuation-within-comments.patch
Description: Text Data

Mike