guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] WIP patches for the rust importer


From: mjbecze
Subject: Re: [PATCH] WIP patches for the rust importer
Date: Wed, 27 Nov 2019 16:36:20 -0800

> I'd love to see what you have so far if you want to share

Okie Dokie, I posted it and cc'd ya.

Also I took a look at your patches.
0001-import-crate-Don-t-include-optional-dependencies.patch should work
just fine with my patch. But
0003-import-crate-Honor-versioned-dependencies-when-impor.patch will not
work.

I took a different route here with the naming. If you are interested take
a look take a look at my second patch. (recusive-import-semver) only will
add the version number to the name if the crate being imported is not the
latest version. I thought this was more inline with the canonical names,
but if always adding version number the export symbol is desirable it will
simplify things.

Also I added a function (find-packages-by-name*/direct) to packages.scm
which will return the export symbol of a package that already exists. I
use this in case there are some non-canocal export name already added.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]