Re: [PATCH 3/3] gnu: Add zpaq.

[Tobias Geerinckx-Rice]

ng0,

On 28/01/17 18:51, ng0 wrote:
> Functionality seems okay:

I've been using (more or less) this package for a month or so, and have
yet to experience catastrophic data loss.

>> +        (string-append "CPPFLAGS=-Dunix"
>> +                       ,(match (or (%current-target-system)
>> +                                   (%current-system))
>> +                               ("x86_64-linux"      "")
>> +                               ("i686-linux"    "")
>> +                               (_               " -DNOJIT")))
>> +        (string-append "CXXFLAGS=-O3 -mtune=generic -DNDEBUG"
>> +                       ,(match (or (%current-target-system)
>> +                                   (%current-system))
>> +                               ("x86_64-linux"  " -march=nocona")
>> +                               ("i686-linux"    " -march=i686")
>> +                               (_               "")))
> 
> Can you add a comment on the CPPFLAGS?

Hmm? The code looks self-documenting to me. I can't really think of a
comment that wouldn't verge on the tautological. What's unclear to you?

I think CXXFLAGS could use one, though. I tried to choose a safe ‘lowest
common denominator’ CPU model for both to keep the package reproducible,
while allowing for some optimisation on x86_64.

Kind regards,

T G-R

signature.asc
Description: OpenPGP digital signature