[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Not patching shebang in git hook samples ?
From: |
Ludovic Courtès |
Subject: |
Re: Not patching shebang in git hook samples ? |
Date: |
Mon, 23 Jan 2017 15:04:30 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
John Darrington <address@hidden> skribis:
> The git package ships with a number of sample hook files. These are shell
> scripts and
> therefore the #!/bin/sh line gets substituted at build time.
>
> However these files get installed into every git repostory that is created,
> and users
> are invited to use them as templates for their own hooks.
>
> This will be fine until both git and bash are updated. Now the original bash
> is free
> to be garbage collected. If that happens, the path:
> #!/gnu/store/qkw4zrwfybxww8f56nkb6hggxambk89b-bash-4.4.0/bin/sh
> will no longer exist.
>
> I suggest what we turn off the shebang patching for the files in
> share/templates for git.
Agreed, it’s a bug.
Ludo’.