guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add emacs-sx.


From: Alex Kost
Subject: Re: [PATCH] gnu: Add emacs-sx.
Date: Thu, 19 Jan 2017 13:11:19 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

ng0 (2017-01-18 11:51 +0000) wrote:

> Alex Kost <address@hidden> writes:
>
>> ng0 (2017-01-15 21:10 +0000) wrote:
>>
>>> From: ng0 <address@hidden>
>>>
>>> * gnu/packages/emacs.scm (emacs-sx): New variable.
>>
>> Thanks, I committed it as 899bcad310.  See the comments below.
>>
>>> ---
>>>  gnu/packages/emacs.scm | 26 +++++++++++++++++++++++++-
>>>  1 file changed, 25 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>>> index 50cea7685..ca038bcb2 100644
>>> --- a/gnu/packages/emacs.scm
>>> +++ b/gnu/packages/emacs.scm
>>> @@ -12,7 +12,7 @@
>>>  ;;; Copyright © 2016 David Thompson <address@hidden>
>>>  ;;; Copyright © 2016 Matthew Jordan <address@hidden>
>>>  ;;; Copyright © 2016 Roel Janssen <address@hidden>
>>> -;;; Copyright © 2016 ng0 <address@hidden>
>>> +;;; Copyright © 2016, 2017 ng0 <address@hidden>
>>
>> So are you going to use this email now?  ".mailmap" still prefers
>> <address@hidden>.
>
> I am slowly fading out the use of my own domains as I see no
> point in paying money for names. Yesterday I have switched all
> the gnu.org lists to this email. The commits still happen with
> the @libertad.pw adress, I see the copyright lines as contact
> information. Some people I know don't use email addresses for
> commits for example.
> I will update the .mailmap later this year, at the point where I
> make my commits with this email address.
> Older commits I am working on for some time now still carry
> various other emails, like the one you commited with emacs-sx.

OK.  Thanks for letting us know.

[...]
>>> +       (sha256
>>> +        (base32
>>> +         "1w0xghfljqg31axcnv8gzlrd8pw25nji6idnrhflq0af9qh1dw03"))))
>>> +    (build-system emacs-build-system)
>>> +    (inputs
>>> +     `(("emacs-markdown-mode" ,emacs-markdown-mode)
>>> +       ("let-alist" ,let-alist)))
>>
>> All emacs dependencies should be propagated, otherwise the package will
>> not work.
>
> Okay, I did not know that. Does the importer know about this?

Yes, since
http://git.savannah.gnu.org/cgit/guix.git/commit/?id=681a555b837d766848baacbed5750e9d30314709

>>> +    (home-page "https://github.com/vermiculus/sx.el/";)
>>> +    (synopsis "Emacs StackExchange client")
>>> +    (description
>>> +     "Emacs StackExchange client.  Ask and answer questions on
>>> +Stack Overflow, Super User, and other StackExchange sites.")
>>> +    (license license:gpl3+)))
>>> +
>>>  (define-public emacs-f
>>>    (package
>>>      (name "emacs-f")
>>
>> Also for those who may wonder, there are a lot of errors like this:
>>
>>   sx-method.el:33:1:Error: Creating directory: No such file or directory, 
>> /homeless-shelter/.emacs.d/.sx
>>
>> This leads to many uncompiled elisp files.  This issue is fixed in
>> master so it should be OK in the next release:
>>
>> https://github.com/vermiculus/sx.el/commit/53816e1885df22391ecc820297c1fe7cd381a630
>
> Did this occur when using the application? For me it worked, but
> I have no StackExchange account, so I just searched and read a
> bit, and no errors occured.

All I wanted to say is that multiple elisp files were not compiled (look
at the build log¹ to see the errors I mentioned).  Missing ".elc" files
can't make an emacs package fail in any way, it will still work but
using ".el" files instead of ".elc".

¹ http://hydra.gnu.org/build/1817230/log/raw

-- 
Alex



reply via email to

[Prev in Thread] Current Thread [Next in Thread]