Re: [PATCH 1/2] gnu: Add loudmouth.

[Mark H Weaver]

ng0 <address@hidden> writes:

> Mark H Weaver <address@hidden> writes:
>
>> ng0 <address@hidden> writes:
>>
>>> * gnu/packages/messaging.scm (loudmouth): New variable.
>>> ---
>>>  gnu/packages/messaging.scm | 32 +++++++++++++++++++++++++++++++-
>>>  1 file changed, 31 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
>>> index 2be3b0969..d6b0d4bbc 100644
>>> --- a/gnu/packages/messaging.scm
>>> +++ b/gnu/packages/messaging.scm
>>> @@ -5,7 +5,7 @@
>>>  ;;; Copyright © 2015 Andreas Enge <address@hidden>
>>>  ;;; Copyright © 2015, 2016 Ricardo Wurmus <address@hidden>
>>>  ;;; Copyright © 2015 Efraim Flashner <address@hidden>
>>> -;;; Copyright © 2016 ng0 <address@hidden>
>>> +;;; Copyright © 2016, 2017 <address@hidden>
>>>  ;;; Copyright © 2016 Andy Patterson <address@hidden>
>>>  ;;; Copyright © 2016, 2017 Clément Lassieur <address@hidden>
>>>  ;;;
>>> @@ -1120,4 +1120,34 @@ Conferencing (PSYC).  psycLPC is a fork of LDMud 
>>> with some new features and
>>>  many bug fixes.")
>>>      (license license:gpl2))))
>>>  
>>> +(define-public loudmouth
>>> +  (package
>>> +    (name "loudmouth")
>>> +    (version "1.5.3")
>>> +    (source
>>> +     (origin
>>> +       (method url-fetch)
>>> +       (uri (string-append "https://mcabber.com/files/loudmouth/";
>>> +                           name "-" version ".tar.bz2"))
>>> +       (sha256
>>> +        (base32
>>> +         "0b6kd5gpndl9nzis3n6hcl0ldz74bnbiypqgqa1vgb0vrcar8cjl"))))
>>> +    (build-system gnu-build-system)
>>> +    (inputs
>>> +     `(("gnutls" ,gnutls)
>>> +       ("glib" ,glib)
>>> +       ("libidn" ,libidn)))
>>> +    (native-inputs
>>> +     `(("pkg-config" ,pkg-config)
>>> +       ("check" ,check)
>>> +       ("glib" ,glib "bin") ; gtester
>>> +       ("gtk-doc" ,gtk-doc)))
>>> +    (home-page "http://mcabber.com/";)
>>> +    (description
>>> +     "Loudmouth is a lightweight and easy-to-use C library for programming
>>> +with the Jabber protocol.  It's designed to be easy to get started with
>>> +and yet extensible to let you do anything the Jabber protocol allows.")
>>> +    (synopsis "Asynchronous XMPP library")
>>> +    (license license:lgpl2.1)))
>>
>> According to Debian, the license is lgpl2.0+.  Can you check this again?
>>
>>       Mark
>>
>
> Sorry for all the mistakes, I wasn't very present when I wrote
> this.
> But, the license is correct. I haven't looked at debian because I
> have the source, and it is 2.1 here.

I just looked, and the source files say this:

  This program is free software; you can redistribute it and/or
  modify it under the terms of the GNU Lesser General Public License as
  published by the Free Software Foundation; either version 2 of the
  License, or (at your option) any later version.

That means lgpl2.0+, as the Debian maintainer concluded.

Have you been concluding the licenses based solely on the COPYING file
(or similar) present in the tarball?  If so, you may have been getting
it wrong for a long time.  The copyright notices in the source files are
the relevant thing to check.  I usually check Debian's copyright files,
since they've already done the hard work.

     Thanks,
       Mark