[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/8] gnu: python-dulwich: Fix tests.
From: |
Danny Milosavljevic |
Subject: |
Re: [PATCH 8/8] gnu: python-dulwich: Fix tests. |
Date: |
Tue, 17 Jan 2017 23:58:40 +0100 |
Hi,
On Tue, 17 Jan 2017 23:55:50 +0100
Marius Bakke <address@hidden> wrote:
> > + (setenv "TEST_RUNNER" "unittest")
> > + (setenv "PYTHONHASHSEED" "random")
> > + (and
> > + ;; Test without c extensions
> > + ;; FIXME someone already called build_ext.
> > + ;(zero? (system* "python" "-m" "unittest"
> > "dulwich.tests.test_suite"))
> > + ;; Test with c extensions
> > + ;(zero? (system* "python" "setup.py" "build_ext" "-i"))
>
> I think build_ext is called as part of the regular build process. Why
> does it need to be called again (with the -i flag)?
It's copied from the .travis file. Since we install the C extension so we
should also test the C extension - and the other test doesn't matter. But I'm
unsure whether to leave the comment in.
- Re: [PATCH 2/8] gnu: Add python-reno., (continued)
- [PATCH 4/8] gnu: Add python-dulwich., Danny Milosavljevic, 2017/01/17
- [PATCH 6/8] gnu: Add python-fastimport., Danny Milosavljevic, 2017/01/17
- [PATCH 7/8] gnu: python-oslosphinx: Add python-reno., Danny Milosavljevic, 2017/01/17
- [PATCH 8/8] gnu: python-dulwich: Fix tests., Danny Milosavljevic, 2017/01/17
- Re: [PATCH 0/8] Make python-oslosphinx work in python-tests branch., Marius Bakke, 2017/01/17
Re: [PATCH 0/8] Make python-oslosphinx work in python-tests branch., ng0, 2017/01/17