[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/16] gnu: Add python-promise.
From: |
Efraim Flashner |
Subject: |
Re: [PATCH 03/16] gnu: Add python-promise. |
Date: |
Mon, 12 Sep 2016 08:31:24 +0300 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Sun, Sep 11, 2016 at 09:41:10PM +0200, David Craven wrote:
> > +(define-public python2-promise
> > + (let ((promise (package-with-python2
> > + (strip-python2-variant python-promise))))
> > + (package (inherit promise)
> > + (arguments (substitute-keyword-arguments (package-arguments promise)
> > + ((#:tests? _) #t)))
>
> I've seen this in a few of your patches. Why do tests fail with python
> but not with python-2?
In this one the tests require python-futures, which is python2 only. I
tried adding python2-futures anyway to the native-inputs but
unsuprisingly it didn't help with the tests. The right fix is to have
upstream change it so that it says (something like)
tests:
require:
"pytest" ,(version < '3' "futures");
but I need to read up more on my python syntax to suggest a patch.
--
Efraim Flashner <address@hidden> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
signature.asc
Description: PGP signature
[PATCH 02/16] gnu: Add python-peewee., Efraim Flashner, 2016/09/11
[PATCH 03/16] gnu: Add python-promise., Efraim Flashner, 2016/09/11
[PATCH 04/16] gnu: Add python-pytest-mock., Efraim Flashner, 2016/09/11
[PATCH 05/16] gnu: Add python-graphql-core., Efraim Flashner, 2016/09/11
[PATCH 06/16] gnu: Add python-graphql-relay., Efraim Flashner, 2016/09/11
[PATCH 07/16] gnu: Add python-sqlalchemy-utils., Efraim Flashner, 2016/09/11
[PATCH 12/16] gnu: Add python-cov-core., Efraim Flashner, 2016/09/11
[PATCH 08/16] gnu: Add python-pytest-django., Efraim Flashner, 2016/09/11
[PATCH 13/16] gnu: Add python-nose2., Efraim Flashner, 2016/09/11