guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add python-contextlib2


From: Ben Woodcroft
Subject: Re: [PATCH] gnu: Add python-contextlib2
Date: Wed, 18 Nov 2015 22:55:37 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

Hi there.

On 18/11/15 18:31, Chris Marusich wrote:
Hi,

I've packaged contextlib2. This is my first submission, so please let
me know if there is anything that should be different about the
changes I've made. Also, if there's anything odd about the way I've
formatted these patches or this email, please let me know so I can
correct it next time.
If I'm understanding correctly, the sole purpose of the patch is to make the tests run. In that case, I think it might be simpler to replace the check phase like so?

    (build-system python-build-system)
    (arguments
     `(#:phases
       (modify-phases %standard-phases
         (replace 'check
           (lambda _ (system* "python" "test_contextlib2.py", "-v"))))))

Thanks for the contribution. I second Andreas' welcome.
ben



reply via email to

[Prev in Thread] Current Thread [Next in Thread]