Re: [PATCH] Add r-devtools.

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> The git2r README says this:
>
>   The libgit2 library has been modified, e.g. to use the R printing and
>   error routines, and to use runif instead of rand.
>
> In other places it says that libgit2 was modified to build it as an R
> package.  As I don’t know what this means I’ve submitted a bug report to
> ask if linking against an external libgit2 would be possible:
>
>   https://github.com/ropensci/git2r/issues/187
>
> I also added a note to the package recipe stating that the package
> contains modified sources of libgit2.

Sounds good.  It’s great that you took the time to check with upstream.

> From 853cd47952dad86f69d7ed9389174cc77eed17e9 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 11 Nov 2015 14:07:24 +0100
> Subject: [PATCH 1/3] gnu: Add r-git2r.
>
> * gnu/packages/statistics.scm (r-git2r): New variable.

[...]

> +    (synopsis "Access git repositories with R")

s/git/Git/

Otherwise LGTM.

> From a8df74bb8cfc34b5ea0f62b56f8fa9ede46c622c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 11 Nov 2015 14:07:47 +0100
> Subject: [PATCH 2/3] gnu: Add r-rstudioapi.
>
> * gnu/packages/statistics.scm (r-rstudioapi): New variable.

LGTM.

> From 9491af491f85afe7f317309946cea34f63af8221 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 11 Nov 2015 14:08:46 +0100
> Subject: [PATCH 3/3] gnu: Add r-devtools.
>
> * gnu/packages/statistics.scm (r-devtools): New variable.

LGTM.

Thanks!

Ludo’.