Re: Timestamps in ...-autoloads.el files

[Ludovic Courtès]

Alex Kost <address@hidden> skribis:

> Ludovic Courtès (2015-11-03 16:27 +0300) wrote:

[...]

>>> +  ;; Avoid non-determinism related to generated timestamps.
>>> +  (setenv "SOURCE_DATE_EPOCH" "1")
>>> +
>>>    ;; The trick is to #:allow-other-keys everywhere, so that each procedure 
>>> in
>>>    ;; PHASES can pick the keyword arguments it's interested in.
>>>    (every (match-lambda
>>
>> Yes, as simple as this.
>
> Great, thanks!  I see that you used (setenv "SOURCE_DATE_EPOCH" "0") in
> 'tk-update' commit, so I also changed the value to "0".

Oh, good point.  I don’t know if it matters much (for Python it seems to
make no difference), but I think “1” is the safest choice because the
mtime on files in the store is set to 1, not 0.  I’ll fix that in
‘tk-update’.

>>>> Could you also submit it upstream, Cc’ing guix-devel and
>>>> address@hidden  Hopefully that is
>>>> acceptable.  (I searched a bit but didn’t find a similar patch by the
>>>> Debian Reproducible team, but patch-tracker.debian.org is unreachable.)
>>>
>>> I'm afraid it's a too hard task for me, sorry.  I wouldn't like to mail
>>> to so many places.
>>
>> Or email only emacs-devel if you prefer.
>>
>> An experienced Emacs hacker like you shouldn’t have to be afraid of that.
>
> After fighting with myself for all these days, I must admit I'm not
> brave enough for this task yet, sorry.

You’re not the one to be sorry.  It tells more about the weaknesses of
the Emacs developer community than about yours.

I’ll post it if you don’t mind.

> From a99fb41a7b84dd28c1a5b3f53cf14ca3c43785e7 Mon Sep 17 00:00:00 2001
> From: Alex Kost <address@hidden>
> Date: Sat, 14 Nov 2015 14:04:43 +0300
> Subject: [PATCH 1/2] build-system/gnu: Set 'SOURCE_DATE_EPOCH'.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> Suggested by Ludovic Courtès <address@hidden>.
>
> * guix/build/gnu-build-system.scm (gnu-build): Set SOURCE_DATE_EPOCH for
>   deterministic builds.

[...]

> +  ;; Avoid non-determinism related to generated timestamps.
> +  (setenv "SOURCE_DATE_EPOCH" "0")

OK with that set to 1.

> From 8ee244b6470b11928aa207cf21527ca33cef31f5 Mon Sep 17 00:00:00 2001
> From: Alex Kost <address@hidden>
> Date: Wed, 21 Oct 2015 15:59:23 +0300
> Subject: [PATCH 2/2] gnu: emacs: Honor 'SOURCE_DATE_EPOCH'.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> Suggested by Ludovic Courtès <address@hidden>.
>
> * gnu/packages/patches/emacs-source-date-epoch.patch: New patch.
> * gnu-system.am (dist_patch_DATA): Add it.
> * gnu/packages/emacs.scm (emacs)[source]: Use it.

OK.

Thank you!

Ludo’.