Re: [PATCH 1/3] gnu: Add c-ares.

[Ludovic Courtès]

Efraim Flashner <address@hidden> skribis:

> * gnu/packages/aria2.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

[...]

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/bagder/c-ares/archive/cares-";
> +                    (string-map (lambda (c) (if (char=? c #\.) #\_ c)) 
> version)
> +                    ".tar.gz"))

Please use the standalone tarball from
http://c-ares.haxx.se/download/c-ares-1.10.0.tar.gz and remove the
autotools from ‘native-inputs’ and the modified phases.

> +    (license license:x11)))

There’s no top-level license file, but the license text in source files
is:

   * Permission to use, copy, modify, and distribute this
   * software and its documentation for any purpose and without
   * fee is hereby granted, provided that the above copyright
   * notice appear in all copies and that both that copyright
   * notice and this permission notice appear in supporting
   * documentation, and that the name of M.I.T. not be used in
   * advertising or publicity pertaining to distribution of the
   * software without specific, written prior permission.
   * M.I.T. makes no representations about the suitability of
   * this software for any purpose.  It is provided "as is"
   * without express or implied warranty.

This is neither <http://directory.fsf.org/wiki/License:Expat> nor
<http://directory.fsf.org/wiki/License:X11>.

Unless someone has a better idea, I would make it:

  (license:x11-style "http://c-ares.haxx.se/license.html";)

Could you send an updated patch?

Thanks,
Ludo’.