Re: [PATCH 1/7] gnu: Add Pod-Simple.

[Eric Bavier]

On Mon, 17 Aug 2015 04:05:56 +0200
Eric Dvorsak <address@hidden> wrote:

> * gnu/packages/perl.scm (perl-pod-simple): New variable.
> ---
>  gnu/packages/perl.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index d2e38cc..7318542 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -3,6 +3,7 @@
>  ;;; Copyright © 2013 Andreas Enge <address@hidden>
>  ;;; Copyright © 2015 Ricardo Wurmus <address@hidden>
>  ;;; Copyright © 2015 Eric Bavier <address@hidden>
> +;;; Copyright © 2015 Eric Dvorsak <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -3941,6 +3942,26 @@ directory specifications in a cross-platform
> manner.") for a given module is comprehensive.")
>      (license (package-license perl))))
>  
> +(define-public perl-pod-simple
> +  (package
> +    (name "perl-pod-simple")
> +    (version "3.30_1")

I think we should avoid using dev releases if we can.  Is there
anything preventing the use of the "3.30" release?

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://search.cpan.org/CPAN/authors/id/M/";

Please use the "cpan" mirror: "mirror://cpan/authors/id/..."

> +                                  "MA/MARCGREEN/Pod-Simple-" version
> +                                  ".tar.gz"))
> +              (sha256
> +               (base32
> +
> "0yzy7mw2jriwcywmh38csjqrwxj207b2b7rlpvkdh1rq5828hary"))))
> +    (build-system perl-build-system)
> +    (home-page
> "http://search.cpan.org/~marcgreen/Pod-Simple/lib/Pod/Simple.pod";)

Could you use the "http://search.cpan.org/dist/Pod-Simple"; url
instead?  It prevents us from needing to update the home-page url if
ownership is ever transferred.

> +    (synopsis "Parsing library for text in Pod format")
> +    (description "Pod::Simple is a Perl library for parsing text in
> +the Pod (plain old documentation) markup language that is typically
> +used for writing documentation for Perl and for Perl modules.")
> +    (license (package-license perl))))
> +
>  (define-public perl-posix-strftime-compiler
>    (package
>      (name "perl-posix-strftime-compiler")

Thanks,
`~Eric