guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] gnu: Add gnome-themes-standard.


From: Ludovic Courtès
Subject: Re: [PATCH 2/2] gnu: Add gnome-themes-standard.
Date: Mon, 03 Nov 2014 23:11:42 +0100
User-agent: Gnus/5.130011 (Ma Gnus v0.11) Emacs/24.3 (gnu/linux)

Federico Beffa <address@hidden> skribis:

> From 7439f19c1f2966466da88554478b796c3bfca429 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <address@hidden>
> Date: Sun, 2 Nov 2014 18:09:33 +0100
> Subject: [PATCH 2/2] gnu: Add gnome-themes-standard.
>
> * gnu/packages/gnome.scm (gnome-themes-standard): New variable.

[...]

> +;; The version of this package should be the same as the version of
> +;; gnome-desktop.
> +(define-public gnome-themes-standard
> +  (package
> +    (name "gnome-themes-standard")
> +    (version "3.10.0")

Please use (version (package-version gnome-desktop)) here, and put the
comment just above it.

> +       (uri (string-append "mirror://gnome/sources/" name "/" 
> +                           (string-take version 4) "/" name "-"

Use ‘version-major+minor’ instead of ‘string-take’.

OK to push with these changes.

Thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]