17/246: gnu: automake-1.16.5: Skip tests.

[guix-commits]

janneke pushed a commit to branch core-packages-team
in repository guix.

commit ce28b37057354103c84e29221ede372d1c213232
Author: Janneke Nieuwenhuizen <janneke@gnu.org>
AuthorDate: Thu Dec 5 19:52:50 2024 +0100

    gnu: automake-1.16.5: Skip tests.
    
    As 23 compiler "tap" tests fail that cannot be easily skipped, disable tests
    altogether.
    
        ERROR: t/depcomp-auto
        =====================
    
        ERROR: t/depcomp-auto.tap - missing test plan
        ERROR: t/depcomp-auto.tap - exited with status 77
    
        ERROR: t/depcomp-cpp
        ====================
    
        ERROR: t/depcomp-cpp.tap - missing test plan
        ERROR: t/depcomp-cpp.tap - exited with status 77
    
        ERROR: t/depcomp-dashmstdout
        ============================
    
        ERROR: t/depcomp-dashmstdout.tap - missing test plan
        ERROR: t/depcomp-dashmstdout.tap - exited with status 77
    
        ERROR: t/depcomp-gcc
        ====================
    
        ERROR: t/depcomp-gcc.tap - missing test plan
        ERROR: t/depcomp-gcc.tap - exited with status 77
    
    * gnu/packages/autotools.scm (automake)[arguments]: Skip tests.  Remove
    "skip-test" phase, as the "tap" tests ERROR out when skipped.
    (automake)[arguments]: Enable tests.  Add, instead of replace, "skip-tests" 
phase.
    
    Change-Id: Iacc2ca3bc84f0a4b261663b9178922bcb1c18578
---
 gnu/packages/autotools.scm | 22 ++++------------------
 1 file changed, 4 insertions(+), 18 deletions(-)

diff --git a/gnu/packages/autotools.scm b/gnu/packages/autotools.scm
index 9a8023f7d3..301c1e9b8f 100644
--- a/gnu/packages/autotools.scm
+++ b/gnu/packages/autotools.scm
@@ -342,6 +342,7 @@ output is indexed in many ways to simplify browsing.")
             (files '("share/aclocal")))))
     (arguments
      (list
+      #:tests? #f ;with gcc-14, 23 compiler "tap" tests fail.
       #:modules '((guix build gnu-build-system)
                   (guix build utils)
                   (srfi srfi-1)
@@ -360,23 +361,6 @@ output is indexed in many ways to simplify browsing.")
                 ;; that occur during the test suite.
                 (setenv "SHELL" sh)
                 (setenv "CONFIG_SHELL" sh))))
-          (add-before 'check 'skip-tests
-            (lambda _
-              (substitute*
-                  ;; This test requires 'etags' and fails if it's missing.
-                  ;; Skip it.
-                  '("t/tags-lisp-space.sh"
-                    ;; These tests fail with gcc-14
-                    "t/c-demo.sh"
-                    "t/depcomp-auto.tap"
-                    "t/depcomp-cpp.tap"
-                    "t/depcomp-dashmstdout.tap"
-                    "t/depcomp-gcc.tap"
-                    "t/dist-vs-built-sources.sh"
-                    "t/link_cond.sh"
-                    "t/subobj-clean-pr10697.sh")
-                  (("^#!.*" all)
-                   (string-append all "exit 77;\n")))))
 
           #$@(if (%current-target-system)
                  #~((add-after 'install 'patch-non-shebang-references
@@ -453,9 +437,11 @@ Makefile, simplifying the entire process for the 
developer.")
                (search-patches "automake-skip-amhello-tests.patch"))))
     (arguments
      (substitute-keyword-arguments (package-arguments automake-1.16.5)
+       ((#:tests? tests?)
+        #t)
        ((#:phases phases)
         #~(modify-phases #$phases
-            (replace 'skip-tests
+            (add-before 'check 'skip-test
               (lambda _
                 (substitute*
                     ;; This test requires 'etags' and fails if it's missing.