guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

16/16: lint: Check that python-pre-commit is not an input.


From: guix-commits
Subject: 16/16: lint: Check that python-pre-commit is not an input.
Date: Sun, 12 Mar 2023 07:14:27 -0400 (EDT)

lbraun pushed a commit to branch master
in repository guix.

commit a70b9fb319e7f8d64ea90e8f659dcf40a6b971b0
Author: Antero Mejr <antero@mailbox.org>
AuthorDate: Sat Mar 11 13:39:45 2023 +0000

    lint: Check that python-pre-commit is not an input.
    
    pre-commit should never be a native-input of python packages, it's a
    package manager for commit linting that is irrelevant to builds.
    
    * guix/lint.scm (check-inputs-should-not-be-an-input-at-all): Add entry
    for python-pre-commit.
    
    Signed-off-by: Lars-Dominik Braun <lars@6xq.net>
---
 guix/lint.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/guix/lint.scm b/guix/lint.scm
index 8e3976171f..17dcc23647 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -533,7 +533,8 @@ of a package, and INPUT-NAMES, a list of package 
specifications such as
   ;; Emit a warning if some inputs of PACKAGE are likely to should not be
   ;; an input at all.
   (let ((input-names '("python-setuptools"
-                       "python-pip")))
+                       "python-pip"
+                       "python-pre-commit")))
     (map (lambda (input)
            (make-warning
             package



reply via email to

[Prev in Thread] Current Thread [Next in Thread]