guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: musescore: Update to 4.0.


From: Liliana Marie Prikler
Subject: Re: [PATCH] gnu: musescore: Update to 4.0.
Date: Thu, 15 Dec 2022 15:55:15 +0100
User-agent: Evolution 3.46.0

Am Mittwoch, dem 14.12.2022 um 18:19 +0100 schrieb Nicolas Goaziou:
>         (snippet
>          ;; Remove unused libraries.
>          '(begin
>             (for-each delete-file-recursively
> -                     '("thirdparty/freetype"
> -                       "thirdparty/openssl"
> -                       "thirdparty/portmidi"
> -                       "thirdparty/qt-google-analytics"))))))
> +                     '("thirdparty/freetype"))))))
I'd prefer if we unbundled more rather than less on updates.
>      (build-system qt-build-system)
>      (arguments
>       `(#:configure-flags
> -       `("-DBUILD_TELEMETRY_MODULE=OFF" ;don't phone home
> -         "-DBUILD_WEBENGINE=OFF"
> -         "-DDOWNLOAD_SOUNDFONT=OFF"
> +       `("-DDOWNLOAD_SOUNDFONT=OFF"
Looking at [1], it appears as though parts of the telemetry module have
been transferred into "diagnostics".  It also appears as though
precompiled binaries are checked into git.  Is enough care taken to
remove those?
> 

Cheers


reply via email to

[Prev in Thread] Current Thread [Next in Thread]