[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
03/06: lint: refresh: Warn about missing or dysfunctional updaters.
From: |
guix-commits |
Subject: |
03/06: lint: refresh: Warn about missing or dysfunctional updaters. |
Date: |
Tue, 6 Apr 2021 18:00:40 -0400 (EDT) |
civodul pushed a commit to branch master
in repository guix.
commit 709f30b8e466b5f7155255be4f2cee008f8d01a9
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Sun Apr 4 22:43:13 2021 +0200
lint: refresh: Warn about missing or dysfunctional updaters.
This feedback should help us improve updaters.
* guix/lint.scm (check-for-updates): Return a warning when PACKAGE lacks
an updater or when the updater returns #f.
---
guix/lint.scm | 41 ++++++++++++++++++++++++++---------------
1 file changed, 26 insertions(+), 15 deletions(-)
diff --git a/guix/lint.scm b/guix/lint.scm
index cdd9dd1..a7d6bbb 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -1191,21 +1191,32 @@ vulnerability records for PACKAGE by calling
PACKAGE-VULNERABILITIES."
(define (check-for-updates package)
"Check if there is an update available for PACKAGE."
- (match (with-networking-fail-safe
- (format #f (G_ "while retrieving upstream info for '~a'")
- (package-name package))
- #f
- (package-latest-release* package))
- ((? upstream-source? source)
- (if (version>? (upstream-source-version source)
- (package-version package))
- (list
- (make-warning package
- (G_ "can be upgraded to ~a")
- (list (upstream-source-version source))
- #:field 'version))
- '()))
- (#f '()))) ; cannot find newer upstream release
+ (match (lookup-updater package)
+ (#f
+ (list (make-warning package (G_ "no updater for ~a")
+ (list (package-name package))
+ #:field 'source)))
+ ((? upstream-updater? updater)
+ (match (with-networking-fail-safe
+ (format #f (G_ "while retrieving upstream info for '~a'")
+ (package-name package))
+ #f
+ (package-latest-release package))
+ ((? upstream-source? source)
+ (if (version>? (upstream-source-version source)
+ (package-version package))
+ (list
+ (make-warning package
+ (G_ "can be upgraded to ~a")
+ (list (upstream-source-version source))
+ #:field 'version))
+ '()))
+ (#f ;cannot find upstream release
+ (list (make-warning package
+ (G_ "updater '~a' failed to find \
+upstream releases")
+ (list (upstream-updater-name updater))
+ #:field 'source)))))))
(define (check-archival package)
- branch master updated (10b01e7 -> ee9c44c), guix-commits, 2021/04/06
- 01/06: gnu-maintenance: Add 'sourceforge' updater., guix-commits, 2021/04/06
- 05/06: services: dovecot: Fix serialization of a free-form-args arguments., guix-commits, 2021/04/06
- 04/06: gnu: Add opensmtpd-filter-rspamd., guix-commits, 2021/04/06
- 02/06: upstream: 'package-latest-release' tries all the matching updaters., guix-commits, 2021/04/06
- 03/06: lint: refresh: Warn about missing or dysfunctional updaters.,
guix-commits <=
- 06/06: gnu: Add camlidl., guix-commits, 2021/04/06