[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
06/10: Fix some links on the compare page
From: |
Christopher Baines |
Subject: |
06/10: Fix some links on the compare page |
Date: |
Sat, 21 Nov 2020 16:11:44 -0500 (EST) |
cbaines pushed a commit to branch master
in repository data-service.
commit 814a5d7cba64698b3499b92854e8aa66f627c80a
Author: Christopher Baines <mail@cbaines.net>
AuthorDate: Sat Nov 21 20:10:46 2020 +0000
Fix some links on the compare page
---
guix-data-service/web/compare/html.scm | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/guix-data-service/web/compare/html.scm
b/guix-data-service/web/compare/html.scm
index e5bbcfc..825d0a7 100644
--- a/guix-data-service/web/compare/html.scm
+++ b/guix-data-service/web/compare/html.scm
@@ -54,9 +54,7 @@
(define query-params
(unless invalid-query?
- (string-append "?base_commit=" base-commit
- "&target_commit=" target-commit
- "&locale=" locale)))
+ (query-parameters->string query-parameters)))
(layout
#:body
@@ -172,17 +170,28 @@
(@ (class "btn-group btn-group-lg")
(role "group"))
(a (@ (class "btn btn-default")
- (href ,(string-append "/compare/packages" query-params)))
+ (href ,(string-append
+ "/"
+ (cond
+ ((eq? mode 'revision) "compare")
+ ((eq? mode 'datetime) "compare-by-datetime"))
+ "/packages?"
+ query-params)))
"Compare packages")
(a (@ (class "btn btn-default")
- (href ,(string-append "/compare/package-derivations"
- query-params)))
+ (href ,(string-append
+ "/"
+ (cond
+ ((eq? mode 'revision) "compare")
+ ((eq? mode 'datetime) "compare-by-datetime"))
+ "/package-derivations?"
+ query-params)))
"Compare package derivations")))
(div
(@ (class "col-sm-6"))
(a (@ (class "btn btn-default btn-lg pull-right")
(href ,(string-append
- "/compare.json" query-params)))
+ "/compare.json?" query-params)))
"View JSON")))
(div
(@ (class "row"))
- branch master updated (3e15900 -> e93da1a), Christopher Baines, 2020/11/21
- 01/10: Avoid crashing when no compare arguments are provided, Christopher Baines, 2020/11/21
- 04/10: Improve the comparison page interface, Christopher Baines, 2020/11/21
- 02/10: Avoid errors in form-horizontal-control, Christopher Baines, 2020/11/21
- 03/10: Specify an invalid parameter message in parse-datetime, Christopher Baines, 2020/11/21
- 05/10: Add default datetimes for compare-by-datetime, Christopher Baines, 2020/11/21
- 06/10: Fix some links on the compare page,
Christopher Baines <=
- 09/10: Consolidate the package derivation comparison code, Christopher Baines, 2020/11/21
- 08/10: Start merging the package derivation comparison code, Christopher Baines, 2020/11/21
- 07/10: Extract out the compare form controls, Christopher Baines, 2020/11/21
- 10/10: Fix the JSON link on the compare package derivations page, Christopher Baines, 2020/11/21