[no subject]

[Mathieu Othacehe]

branch: master
commit c5a975867e2af705a809e706d1509ce1f8e67ea8
Author: Mathieu Othacehe <othacehe@gnu.org>
AuthorDate: Tue Sep 15 11:19:53 2020 +0200

    metrics: Warn about metric insertion.
    
    * src/cuirass/metrics.scm: Add a warning about metric insertion in %metrics
    list.
---
 src/cuirass/metrics.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/cuirass/metrics.scm b/src/cuirass/metrics.scm
index f6fcd7f..665b9a0 100644
--- a/src/cuirass/metrics.scm
+++ b/src/cuirass/metrics.scm
@@ -103,6 +103,8 @@ date('now'));")))
 ;;; Definitions.
 ;;;
 
+;; XXX: Make sure to add new metrics at the *end of the list* only, as they
+;; are indexed by position in database.
 (define %metrics
   (list
    ;; Average evaluation duration per specification.
@@ -110,10 +112,12 @@ date('now'));")))
     (id 'average-10-last-eval-duration-per-spec)
     (compute-proc
      (cut db-average-eval-duration-per-spec <> #:limit 10)))
+
    (metric
     (id 'average-100-last-eval-duration-per-spec)
     (compute-proc
      (cut db-average-eval-duration-per-spec <> #:limit 100)))
+
    (metric
     (id 'average-eval-duration-per-spec)
     (compute-proc db-average-eval-duration-per-spec))