02/05: Improve select-builds-with-context

[Christopher Baines]

cbaines pushed a commit to branch master
in repository data-service.

commit 69d3c83986233daa7bab7beb382a79274f9fe7af
Author: Christopher Baines <mail@cbaines.net>
AuthorDate: Fri Jul 3 20:32:45 2020 +0100

    Improve select-builds-with-context
    
    Support specifying the limit, and improve the ordering.
---
 guix-data-service/model/build.scm | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/guix-data-service/model/build.scm 
b/guix-data-service/model/build.scm
index ac1e870..23e94bd 100644
--- a/guix-data-service/model/build.scm
+++ b/guix-data-service/model/build.scm
@@ -119,7 +119,8 @@ ORDER BY status"))
 
 (define* (select-builds-with-context conn build-statuses build-server-ids
                                      #:key revision-commit
-                                     system target)
+                                     system target
+                                     limit)
   (define where-conditions
     (filter
      string?
@@ -180,8 +181,12 @@ ON latest_build_status.build_id = builds.id
                         "WHERE "
                         (string-join where-conditions " AND ")))
                    "
-ORDER BY latest_build_status.timestamp DESC
-LIMIT 100"))
+ORDER BY latest_build_status.timestamp DESC NULLS LAST, derivations.file_name
+"
+                   (if limit
+                       (string-append
+                        "LIMIT " (number->string limit))
+                       "")))
 
   (exec-query-with-null-handling conn
                                  query