guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: branch master updated: licenses: Export license record.


From: Ludovic Courtès
Subject: Re: branch master updated: licenses: Export license record.
Date: Thu, 23 Apr 2020 21:56:57 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hi!

address@hidden skribis:

> commit f0779922ff260df2404c90504986aa59553154fb
> Author: zimoun <address@hidden>
> AuthorDate: Thu Apr 23 16:09:00 2020 +0200
>
>     licenses: Export license record.
>     
>     * guix/licenses.scm (<license>): Export it.
>     
>     Signed-off-by: Mathieu Othacehe <address@hidden>

> -  #:export (license? license-name license-uri license-comment
> +  #:export (license license? license-name license-uri license-comment

I see two issues:

  1. The commit log doesn’t match the change.  :-)

  2. It’s on purpose that the constructor is not exported.  It’s so that
     genuine license objects have to be defined here.  (Likewise, record
     type descriptors like <license> are generally kept private to
     maintain encapsulation.)

I’m in favor of reverting.

What’s the use case, Simon?  (Apologies if I missed the discussion!)

Thanks,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]