guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

03/07: services: account: Have 'user-processes' depend on 'user-homes'.


From: guix-commits
Subject: 03/07: services: account: Have 'user-processes' depend on 'user-homes'.
Date: Fri, 17 Apr 2020 17:19:42 -0400 (EDT)

civodul pushed a commit to branch master
in repository guix.

commit 1e7281108be5fc37daa4cc180e0effdeb4c1a960
Author: Ludovic Courtès <address@hidden>
AuthorDate: Fri Apr 17 12:48:06 2020 +0200

    services: account: Have 'user-processes' depend on 'user-homes'.
    
    Until now, 'user-homes' happened to start right after 'user-processes'
    and before services that depend on a home directory but the dependency
    was not explicit.  This addresses it.
    
    * gnu/system/shadow.scm (account-service-type): Extend
    USER-PROCESSES-SERVICE-TYPE.
---
 gnu/system/shadow.scm | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/gnu/system/shadow.scm b/gnu/system/shadow.scm
index 42480e8..a6f1d80 100644
--- a/gnu/system/shadow.scm
+++ b/gnu/system/shadow.scm
@@ -1,5 +1,5 @@
 ;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Courtès 
<address@hidden>
+;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020 Ludovic Courtès 
<address@hidden>
 ;;; Copyright © 2016 Alex Griffin <address@hidden>
 ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <address@hidden>
 ;;; Copyright © 2020 Efraim Flashner <address@hidden>
@@ -314,9 +314,7 @@ accounts among ACCOUNTS+GROUPS."
   ;;
   ;; XXX: We arrange for this service to stop right after it's done its job so
   ;; that 'guix system reconfigure' knows that it can reload it fearlessly
-  ;; (and thus create new home directories).  The cost of this hack is that
-  ;; there's a small window during which first-time logins could happen before
-  ;; the home directory has been created.
+  ;; (and thus create new home directories).
   (list (shepherd-service
          (requirement '(file-systems))
          (provision '(user-homes))
@@ -374,6 +372,11 @@ the /etc/skel directory for those."
                                           account-activation)
                        (service-extension shepherd-root-service-type
                                           account-shepherd-service)
+                       ;; Have 'user-processes' depend on 'user-homes' so that
+                       ;; daemons start after their home directory has been
+                       ;; created.
+                       (service-extension user-processes-service-type
+                                          (const '(user-homes)))
                        (service-extension etc-service-type
                                           etc-files)))))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]