[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
06/11: derivations: Don't memoize 'derivation->bytevector'.
|
From: |
guix-commits |
|
Subject: |
06/11: derivations: Don't memoize 'derivation->bytevector'. |
|
Date: |
Sun, 27 Oct 2019 18:13:08 -0400 (EDT) |
civodul pushed a commit to branch master
in repository guix.
commit d727a9343d861cf775645df8be5bfefd43d6c6f0
Author: Ludovic Courtès <address@hidden>
Date: Sun Oct 27 19:19:14 2019 +0100
derivations: Don't memoize 'derivation->bytevector'.
Its hit rate was only 8%. Removing it reduces heap size of "guix build
libreoffice -nd" from 69MiB to 61MiB and the wall-clock time is unchanged.
* guix/derivations.scm (derivation->bytevector): Change from 'mlambda'
to 'lambda'.
---
guix/derivations.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guix/derivations.scm b/guix/derivations.scm
index 140c22b..706c650 100644
--- a/guix/derivations.scm
+++ b/guix/derivations.scm
@@ -622,7 +622,7 @@ that form."
(display ")" port))))
(define derivation->bytevector
- (mlambda (drv)
+ (lambda (drv)
"Return the external representation of DRV as a UTF-8-encoded string."
(with-fluids ((%default-port-encoding "UTF-8"))
(call-with-values open-bytevector-output-port
- branch master updated (6d18427 -> b13b938), guix-commits, 2019/10/27
- 02/11: derivations: 'build-expression->derivation' caches its module derivations., guix-commits, 2019/10/27
- 01/11: derivations: Introduce 'imported+compiled-modules'., guix-commits, 2019/10/27
- 04/11: store: Allow objects in the cache to be inserted and search for with 'equal?'., guix-commits, 2019/10/27
- 03/11: gexp: Add 'imported+compiled-modules'., guix-commits, 2019/10/27
- 10/11: pull: Honor '/etc/guix/channels.scm'., guix-commits, 2019/10/27
- 08/11: gnu: bootstrap: Cache the 'bootstrap-executable' origins., guix-commits, 2019/10/27
- 06/11: derivations: Don't memoize 'derivation->bytevector'.,
guix-commits <=
- 05/11: gexp: Cache the module to derivation mappings., guix-commits, 2019/10/27
- 11/11: news: Add entry for /etc/guix/channels.scm., guix-commits, 2019/10/27
- 07/11: gnu: bootstrap: 'bootstrap-origin' preserves eq?-ness when no changes are made., guix-commits, 2019/10/27
- 09/11: channels: Refer to 'guile-json-3'., guix-commits, 2019/10/27