guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

05/05: tests: Skip unreliable "herd invalidate nscd" test.


From: guix-commits
Subject: 05/05: tests: Skip unreliable "herd invalidate nscd" test.
Date: Wed, 15 May 2019 06:19:05 -0400 (EDT)

civodul pushed a commit to branch master
in repository guix.

commit 33572a36624aa1c5cca409cfee36eb67982f4891
Author: Ludovic Court├Ęs <address@hidden>
Date:   Wed May 15 12:14:58 2019 +0200

    tests: Skip unreliable "herd invalidate nscd" test.
    
    * gnu/tests/base.scm (run-basic-test)["nscd invalidate action, wrong
    table"]: Skip unconditionally.
---
 gnu/services/base.scm | 4 ++--
 gnu/tests/base.scm    | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 015d873..f709ca5 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -1294,8 +1294,8 @@ the tty to run, among other things."
                (lambda args
                  ;; There's a race with the SIGCHLD handler, which could
                  ;; call 'waitpid' before 'close-pipe' above does.  If we
-                 ;; get ECHILD, that means we lost the race, but that's
-                 ;; fine.
+                 ;; get ECHILD, that means we lost the race; in that case, we
+                 ;; cannot tell what the exit code was (FIXME).
                  (or (= ECHILD (system-error-errno args))
                      (apply throw args)))))
             (line
diff --git a/gnu/tests/base.scm b/gnu/tests/base.scm
index cf942fe..247f237 100644
--- a/gnu/tests/base.scm
+++ b/gnu/tests/base.scm
@@ -382,6 +382,9 @@ info --version")
                                                     result)
                              marionette))
 
+          ;; FIXME: The 'invalidate' action can't reliably obtain the exit
+          ;; code of 'nscd' so skip this test.
+          (test-skip 1)
           (test-equal "nscd invalidate action, wrong table"
             '(#f)                                 ;one value, #f
             (marionette-eval '(with-shepherd-action 'nscd ('invalidate "xyz")



reply via email to

[Prev in Thread] Current Thread [Next in Thread]