guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

03/05: vm: Don't try to modify the bind-mounted store.


From: Ludovic Courtès
Subject: 03/05: vm: Don't try to modify the bind-mounted store.
Date: Tue, 26 Jun 2018 08:29:58 -0400 (EDT)

civodul pushed a commit to branch master
in repository guix.

commit a7751eeb574e92b7d629e00f71a4207a52a3a62e
Author: Ludovic Courtès <address@hidden>
Date:   Tue Jun 26 11:34:28 2018 +0200

    vm: Don't try to modify the bind-mounted store.
    
    Previously 'guix system disk-image --file-system-type=iso9660' would
    fail because 'register-closure' would try to reset timestamps/ownership
    on the bind-mounted store, which fails with EPERM.
    
    * gnu/build/vm.scm (make-iso9660-image): Pass #:reset-timestamps? to
    'register-closure'.
---
 gnu/build/vm.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/build/vm.scm b/gnu/build/vm.scm
index 73d0191..312500d 100644
--- a/gnu/build/vm.scm
+++ b/gnu/build/vm.scm
@@ -420,8 +420,10 @@ GRUB configuration and OS-DRV as the stuff in it."
                   (register-closure
                    "/tmp/root"
                    (string-append "/xchg/" closure)
-                   ;; XXX: Using deduplication causes cross device link errors.
-                   #:deduplicate? #f))
+                   ;; TARGET-STORE is a read-only bind-mount so we shouldn't 
try
+                   ;; to modify it.
+                   #:deduplicate? #f
+                   #:reset-timestamps? #f))
                 closures))
 
     (apply invoke



reply via email to

[Prev in Thread] Current Thread [Next in Thread]