[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
02/03: build: Warn against long hash bang lines for tests.
From: |
Ludovic Courtès |
Subject: |
02/03: build: Warn against long hash bang lines for tests. |
Date: |
Tue, 12 Jan 2016 16:48:39 +0000 |
civodul pushed a commit to branch master
in repository guix.
commit 27ab3cee754d89135083b778a00675d9a2d00415
Author: Ludovic Courtès <address@hidden>
Date: Tue Jan 12 16:08:19 2016 +0100
build: Warn against long hash bang lines for tests.
* m4/guix.m4 (GUIX_TEST_HASH_BANG_LENGTH): New macro.
(GUIX_CHECK_FILE_NAME_LIMITS): Use it. Warn against long hash bang
lines in tests.
---
m4/guix.m4 | 14 +++++++++++++-
1 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/m4/guix.m4 b/m4/guix.m4
index 1e5985b..96319b2 100644
--- a/m4/guix.m4
+++ b/m4/guix.m4
@@ -1,5 +1,5 @@
dnl GNU Guix --- Functional package management for GNU
-dnl Copyright © 2012, 2013, 2014, 2015 Ludovic Courtès <address@hidden>
+dnl Copyright © 2012, 2013, 2014, 2015, 2016 Ludovic Courtès <address@hidden>
dnl Copyright © 2014 Mark H Weaver <address@hidden>
dnl
dnl This file is part of GNU Guix.
@@ -204,6 +204,14 @@ AC_DEFUN([GUIX_HASH_BANG_LENGTH], [
[ac_cv_guix_hash_bang_length=`echo -n
"$storedir/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-bootstrap-binaries-0/bin/bash" | wc
-c`])
])
+dnl GUIX_TEST_HASH_BANG_LENGTH
+AC_DEFUN([GUIX_TEST_HASH_BANG_LENGTH], [
+ AC_REQUIRE([GUIX_TEST_ROOT_DIRECTORY])
+ AC_CACHE_CHECK([the length of a hash bang line used in tests],
+ [ac_cv_guix_test_hash_bang_length],
+ [ac_cv_guix_test_hash_bang_length=`echo -n
"$ac_cv_guix_test_root/store/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-bootstrap-binaries-0/bin/bash"
| wc -c`])
+])
+
dnl GUIX_CHECK_FILE_NAME_LIMITS
dnl
dnl GNU/Linux has a couple of silly limits that we can easily run into.
@@ -212,6 +220,7 @@ AC_DEFUN([GUIX_CHECK_FILE_NAME_LIMITS], [
AC_REQUIRE([GUIX_SOCKET_FILE_NAME_LENGTH])
AC_REQUIRE([GUIX_TEST_SOCKET_FILE_NAME_LENGTH])
AC_REQUIRE([GUIX_HASH_BANG_LENGTH])
+ AC_REQUIRE([GUIX_TEST_HASH_BANG_LENGTH])
if test "$ac_cv_guix_socket_file_name_length" -ge ]SOCKET_FILE_NAME_LIMIT[;
then
AC_MSG_ERROR([socket file name would exceed the maxium allowed length])
@@ -222,6 +231,9 @@ AC_DEFUN([GUIX_CHECK_FILE_NAME_LIMITS], [
if test "$ac_cv_guix_hash_bang_length" -ge ]LINUX_HASH_BANG_LIMIT[; then
AC_MSG_ERROR([store directory '$storedir' would lead to overly long
hash-bang lines])
fi
+ if test "$ac_cv_guix_test_hash_bang_length" -ge ]LINUX_HASH_BANG_LIMIT[; then
+ AC_MSG_WARN([test directory '$ac_cv_guix_test_root' may lead to overly
long hash-bang lines])
+ fi
])
dnl GUIX_CHECK_CXX11