[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
24/27: Chroot builds: Provide world-readable /nix/store
From: |
Ludovic Courtès |
Subject: |
24/27: Chroot builds: Provide world-readable /nix/store |
Date: |
Wed, 03 Jun 2015 22:00:46 +0000 |
civodul pushed a commit to branch nix
in repository guix.
commit 44f1b1851ccf836411ca09f5ebc50fc08d92e7e8
Author: Eelco Dolstra <address@hidden>
Date: Thu Apr 2 16:59:40 2015 +0200
Chroot builds: Provide world-readable /nix/store
This was causing NixOS VM tests to fail mysteriously since
5ce50cd99e740d0d0f18c30327ae687be9356553. Nscd could (sometimes) no
longer read /etc/hosts:
open("/etc/hosts", O_RDONLY|O_CLOEXEC) = -1 EACCES (Permission denied)
Probably there was some wacky interaction between the guest kernel and
the 9pfs implementation in QEMU.
---
nix/libstore/build.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc
index 9a69a79..f3a4a45 100644
--- a/nix/libstore/build.cc
+++ b/nix/libstore/build.cc
@@ -1826,7 +1826,7 @@ void DerivationGoal::startBuilder()
build user. */
Path chrootStoreDir = chrootRootDir + settings.nixStore;
createDirs(chrootStoreDir);
- chmod_(chrootStoreDir, 0730);
+ chmod_(chrootStoreDir, 0735);
if (chown(chrootStoreDir.c_str(), 0, buildUser.getGID()) == -1)
throw SysError(format("cannot change ownership of ‘%1%’") %
chrootStoreDir);
- 14/27: Set /nix/store permission to 1737, (continued)
- 14/27: Set /nix/store permission to 1737, Ludovic Courtès, 2015/06/03
- 16/27: Doh^2, Ludovic Courtès, 2015/06/03
- 17/27: Simplify printHash32, Ludovic Courtès, 2015/06/03
- 18/27: Simplify parseHash32, Ludovic Courtès, 2015/06/03
- 19/27: Use pivot_root in addition to chroot when possible, Ludovic Courtès, 2015/06/03
- 15/27: Doh, Ludovic Courtès, 2015/06/03
- 22/27: Tighten permissions on chroot directories, Ludovic Courtès, 2015/06/03
- 20/27: Use chroots for all derivations, Ludovic Courtès, 2015/06/03
- 25/27: Revert /nix/store permission back to 01775, Ludovic Courtès, 2015/06/03
- 21/27: Fix typos: s/the the/the/, Ludovic Courtès, 2015/06/03
- 24/27: Chroot builds: Provide world-readable /nix/store,
Ludovic Courtès <=
- 23/27: addToStore(): Take explicit name argument, Ludovic Courtès, 2015/06/03
- 27/27: Don't let unprivileged users repair paths, Ludovic Courtès, 2015/06/03
- 26/27: Add a ‘verifyStore’ RPC, Ludovic Courtès, 2015/06/03