[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] In string-split, add support for character sets and predicat
|
From: |
Mark H Weaver |
|
Subject: |
Re: [PATCH] In string-split, add support for character sets and predicates. |
|
Date: |
Tue, 09 Oct 2012 22:14:56 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Daniel Hartwig <address@hidden> writes:
> On 10 October 2012 01:48, Mark H Weaver <address@hidden> wrote:
>> Please drop the unneeded curly braces above.
>
> Are guile's macros safe to always use that way?
They should be. If they aren't, that's a bug IMO.
> In libguile/__scm.h
> the SCM_ASSERT definition is conditional on SCM_RECKLESS and appears
> unsafe without the block.
Looks safe to me. If SCM_RECKLESS is set, then 'SCM_ASSERT(...)'
becomes the empty string, but the immediately following ';' remains
and becomes a C null statement.
Your latest patch looks good, but I just remembered one more thing:
doc/ref/api-data.texi needs to be updated.
Are you willing? :)
Thanks!
Mark
- [PATCH] In string-split, add support for character sets and predicates., Daniel Hartwig, 2012/10/08
- Re: [PATCH] In string-split, add support for character sets and predicates., Mark H Weaver, 2012/10/08
- Re: [PATCH] In string-split, add support for character sets and predicates., Daniel Hartwig, 2012/10/08
- Re: [PATCH] In string-split, add support for character sets and predicates., Mark H Weaver, 2012/10/09
- Re: [PATCH] In string-split, add support for character sets and predicates., Daniel Hartwig, 2012/10/09
- Re: [PATCH] In string-split, add support for character sets and predicates.,
Mark H Weaver <=
- Re: [PATCH] In string-split, add support for character sets and predicates., Daniel Hartwig, 2012/10/09
- Re: [PATCH] In string-split, add support for character sets and predicates., Mark H Weaver, 2012/10/09
- Re: [PATCH] In string-split, add support for character sets and predicates., Daniel Hartwig, 2012/10/09
- Re: [PATCH] In string-split, add support for character sets and predicates., Mark H Weaver, 2012/10/10
- Re: [PATCH] In string-split, add support for character sets and predicates., Ludovic Courtès, 2012/10/10
- Re: [PATCH] In string-split, add support for character sets and predicates., Daniel Hartwig, 2012/10/12
- Re: [PATCH] In string-split, add support for character sets and predicates., Mark H Weaver, 2012/10/12
- Re: [PATCH] In string-split, add support for character sets and predicates., Ludovic Courtès, 2012/10/10