Re: [PATCH] Add implementation of SRFI 38

[Andreas Rottmann]

address@hidden (Ludovic Courtès) writes:

> Hi Andreas!
>
> Andreas Rottmann <address@hidden> writes:
>
>> +++ b/module/srfi/srfi-38.scm
>> @@ -0,0 +1,203 @@
>> +;; Copyright (C) Andreas Rottmann 2010.
>
> Should be FSF.  :-)
>
Fixed.

>> +;; Copyright (C) Ray Dillinger 2003. All Rights Reserved.
>
> Alex Shinn should be mentioned, though without “copyright” since he’s
> not a copyright holder strictly speaking.
>
Added a line mentioning Alex.

>> +;; Permission is hereby granted, free of charge, to any person obtaining
>> +;; a copy of this software and associated documentation files (the
>> +;; "Software"), to deal in the Software without restriction, including
>> +;; without limitation the rights to use, copy, modify, merge, publish,
>> +;; distribute, sublicense, and/or sell copies of the Software, and to
>> +;; permit persons to whom the Software is furnished to do so, subject to
>> +;; the following conditions:
>> +
>> +;; The above copyright notice and this permission notice shall be
>> +;; included in all copies or substantial portions of the Software.
>
> I wonder what “sublicense” above mean given that the permission notice
> must remain.  For instance, we could distribute it under the LGPL but
> the original license would still be applicable, right?
>
IANAL, but I think that means you could redistribute under LGPL (which
imposes additional restrictions, most notably "no sublicensing"), as
long as you *also* abide the original license -- which just requires
keeping the license statement (which would then no longer be fully
applicable).  But again, IANAL, and this is mere speculation on my part.

>> +++ b/test-suite/tests/srfi-38.test
>> @@ -0,0 +1,50 @@
>> +;; -*- scheme -*-
>> +
>> +(define-module (test-srfi-38)
>
> Please add the copyright/license header.
>
Done.

srfi-38.diff
Description: Text Data

Thanks, Rotty
-- 
Andreas Rottmann -- <http://rotty.yi.org/>