[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Pkgsrc patches: patch-ag
From: |
Greg Troxel |
Subject: |
Re: Pkgsrc patches: patch-ag |
Date: |
Mon, 18 Feb 2008 09:29:40 -0500 |
User-agent: |
Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (berkeley-unix) |
address@hidden (Ludovic Courtès) writes:
> Greg Troxel <address@hidden> writes:
>
>> Fix for solaris, but I thinh preserves behavior on C99 machines.
>>
>> $NetBSD: patch-ag,v 1.5 2007/07/20 00:09:22 gdt Exp $
>>
>> solaris-2.9 does not have stdint.h but does have inttypes.h
>>
>> --- libguile/c-tokenize.c.orig 2007-06-13 18:00:56.000000000 -0400
>> +++ libguile/c-tokenize.c
>> @@ -39,7 +39,12 @@
>> #define __STDC_LIMIT_MACROS 1
>> #endif
>>
>> +#ifdef HAVE_STDINT_H
>> +#include <stdint.h> /* May break IA64 test-noansi-r */
>> +#else
>> #include <inttypes.h>
>> +#endif
>
> First, the comment and the patch are contradictory. A bit of googling
> seems to confirm the comment, in which case the patch isn't needed.
>
> Second, C99 requires both (Sections 7.18 and 7.8).
>
> Third, the `#include' is within a `#if __STDC_VERSION__ >= 199901L', so
> only C99 systems get to include it.
>
> Fourth, this is a Flex-generated file, so it'd be nice to avoid patching
> it.
>
> Just to say that I'm dubious about this patch. :-)
I think the issue is that some versions of solaris do not have stdint.h,
but do have inttypes.h. But, the patch may be wrong in dealing with it.
Does guile have a position on supporting systems that don't conform to
C99? I'm wondering if I should try to figure this out and get a fix
that is reasonable (I agree this one is gross and likely wrong), or just
punt.
- Re: Honor `$TMPDIR' in `guile-snarf', (continued)
- Re: Honor `$TMPDIR' in `guile-snarf', Aleksej Saushev, 2008/02/14
- Pkgsrc patches, Ludovic Courtès, 2008/02/14
- Re: Pkgsrc patches, Greg Troxel, 2008/02/15
- patches from pkgsrc - patch-aa, Greg Troxel, 2008/02/15
- Re: patches from pkgsrc - patch-aa, Ludovic Courtès, 2008/02/16
- Re: Pkgsrc patches: patch-ae, Greg Troxel, 2008/02/15
- Re: Pkgsrc patches: patch-ae, Ludovic Courtès, 2008/02/16
- Re: Pkgsrc patches: patch-ae, Greg Troxel, 2008/02/18
- Re: Pkgsrc patches: patch-ag, Greg Troxel, 2008/02/15
- Re: Pkgsrc patches: patch-ag, Ludovic Courtès, 2008/02/16
- Re: Pkgsrc patches: patch-ag,
Greg Troxel <=
- Re: Pkgsrc patches: patch-ag, Ludovic Courtès, 2008/02/18
- Re: Pkgsrc patches: patch-ag, Greg Troxel, 2008/02/18
- Re: Pkgsrc patches: patch-ah, Greg Troxel, 2008/02/15
- Re: Pkgsrc patches: patch-aj, Greg Troxel, 2008/02/15
- Re: Pkgsrc patches: patch-aj, Neil Jerram, 2008/02/26
- Re: Pkgsrc patches: patch-aj, Greg Troxel, 2008/02/26
- Re: Pkgsrc patches: patch-aj, Greg Troxel, 2008/02/27
- Re: Pkgsrc patches: patch-aj, Neil Jerram, 2008/02/27
- Re: Pkgsrc patches, Greg Troxel, 2008/02/15