[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Guile-commits] 02/07: Remove thread-exited? check in sigaction
From: |
Andy Wingo |
Subject: |
[Guile-commits] 02/07: Remove thread-exited? check in sigaction |
Date: |
Sun, 8 Jan 2017 14:51:35 +0000 (UTC) |
wingo pushed a commit to branch master
in repository guile.
commit ca598d31405ac77d5515a3d0b70eda9d41b5bf10
Author: Andy Wingo <address@hidden>
Date: Sun Jan 8 12:26:10 2017 +0100
Remove thread-exited? check in sigaction
* libguile/scmsigs.c (scm_sigaction_for_thread): Remove check that
thread hadn't exited. This check was racy as it's always possible
that the other thread exits between checking it or even after the
signal handler is installed.
---
libguile/scmsigs.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/libguile/scmsigs.c b/libguile/scmsigs.c
index 36143af..f210380 100644
--- a/libguile/scmsigs.c
+++ b/libguile/scmsigs.c
@@ -327,11 +327,7 @@ SCM_DEFINE (scm_sigaction_for_thread, "sigaction", 1, 3, 0,
if (SCM_UNBNDP (thread))
thread = scm_current_thread ();
else
- {
- SCM_VALIDATE_THREAD (4, thread);
- if (scm_c_thread_exited_p (thread))
- SCM_MISC_ERROR ("thread has already exited", SCM_EOL);
- }
+ SCM_VALIDATE_THREAD (4, thread);
scm_i_ensure_signal_delivery_thread ();
- [Guile-commits] branch master updated (a0656ad -> b392d81), Andy Wingo, 2017/01/08
- [Guile-commits] 02/07: Remove thread-exited? check in sigaction,
Andy Wingo <=
- [Guile-commits] 01/07: Thread prepare-to-wait respects block_asyncs, Andy Wingo, 2017/01/08
- [Guile-commits] 03/07: Remove thread-specific admin mutex, Andy Wingo, 2017/01/08
- [Guile-commits] 04/07: Enable interrupts only when running thread body, Andy Wingo, 2017/01/08
- [Guile-commits] 06/07: Exited threads retain less memory, Andy Wingo, 2017/01/08
- [Guile-commits] 05/07: Prevent some interrupts of wait-condition-variable, Andy Wingo, 2017/01/08
- [Guile-commits] 07/07: Fix close-port race., Andy Wingo, 2017/01/08