[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Guile-avahi-bugs] Fix build with Guile 3.
From: |
Mathieu Othacehe |
Subject: |
Re: [Guile-avahi-bugs] Fix build with Guile 3. |
Date: |
Mon, 26 Oct 2020 17:59:21 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hello,
> This is incredible! For making the first Guile-Avahi patches has seen
> in more than a decade, you have just won admin rights on the project;
> congrats! :-)
Thanks, the source code aged well, not much work to port it to Guile 3
:).
> I’m not sure why this change is needed. Is it because the 'quit
> exception would be caught somewhere and thus ‘exit’ has no effect?
The exit in the dynamic-wind thunk will cause a stack rewind and we
end-up calling the (exit 1) from the unwind handler every time.
> No need to add this file: it’s automatically added by ‘automake’.
It seems that there's a bug in automake, specifying GUILE_FLAGS in
configure.ac makes "autoreconf" unable to create the config.rpath file
for some reason.
I pushed those commits, created a 0.4 release and the according Guix
package. Do you happen to remember how to upload a release tarball in
savannah?
Thanks for reviewing!
Mathieu