[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v4 2/6] ieee1275: drop len -= 1 quirk in heap_init

From: Stefan Berger
Subject: [PATCH v4 2/6] ieee1275: drop len -= 1 quirk in heap_init
Date: Mon, 6 Feb 2023 10:03:21 -0500

From: Daniel Axtens <>

This was apparently 'required by some firmware': commit dc9468500919
("2007-02-12  Hollis Blanchard  <>").

It's not clear what firmware that was, and what platform from 14 years ago
which exhibited the bug then is still both in use and buggy now.

It doesn't cause issues on qemu (mac99 or pseries) or under PFW for Power8.

I don't have access to old Mac hardware, but if anyone feels especially
strongly we can put it under some feature flag. I really want to disable
it under pseries because it will mess with region merging.

Signed-off-by: Daniel Axtens <>
Reviewed-by: Daniel Kiper <>
 grub-core/kern/ieee1275/init.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/grub-core/kern/ieee1275/init.c b/grub-core/kern/ieee1275/init.c
index 0bc571e3e..bb234b268 100644
--- a/grub-core/kern/ieee1275/init.c
+++ b/grub-core/kern/ieee1275/init.c
@@ -166,7 +166,6 @@ heap_init (grub_uint64_t addr, grub_uint64_t len, 
grub_memory_type_t type,
          addr = 0x180000;
-  len -= 1; /* Required for some firmware.  */
   /* Never exceed HEAP_MAX_SIZE  */
   if (*total + len > HEAP_MAX_SIZE)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]