Re: [PATCH v4 04/15] gdb: Move runtime module loading into runtime_load_module

[Daniel Kiper]

On Thu, Dec 15, 2022 at 11:29:27PM -0600, Glenn Washburn wrote:

Why? Could you add that to the commit message?

> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
>  grub-core/gdb_grub.in | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/grub-core/gdb_grub.in b/grub-core/gdb_grub.in
> index fc17e3d899..d525a5a11f 100644
> --- a/grub-core/gdb_grub.in
> +++ b/grub-core/gdb_grub.in
> @@ -71,16 +71,22 @@ document load_all_modules
>       Load debugging information for all loaded modules.
>  end
>
> +define runtime_load_module
> +     break grub_dl_add
> +     commands
> +             silent
> +             load_module mod
> +             cont
> +     end
> +end
> +document runtime_load_module
> +     Load module symbols at runtime as they are loaded.
> +end
> +
>  ###
>
>  set confirm off
>  file kernel.exec
>  target remote :1234
>
> -# inform when module is loaded
> -break grub_dl_add
> -commands
> -     silent
> -     load_module mod
> -     cont
> -end
> +runtime_load_module

Daniel