[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] read: Fix overflow in grub_getline()
From: |
Daniel Kiper |
Subject: |
Re: [PATCH] read: Fix overflow in grub_getline() |
Date: |
Thu, 29 Sep 2022 17:46:21 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Thu, Aug 25, 2022 at 07:59:09PM -0500, Glenn Washburn wrote:
> From: Li Gen <ligenlive@gmail.com>
>
> Store returned value from grub_getkey() in int instead of char to
> prevent throwing away the extended bits. This was a problem because,
> for instance, the left arrow key press would return
> (GRUB_TERM_EXTENDED | 0x4b), which would have the GRUB_TERM_EXTENDED
> thrown away leaving 0x4b or 'K'. These extended keys should either
> work as intended or do nothing. This change has them do nothing, instead
> of inserting a key not pressed by the user.
>
> Signed-off-by: Li Gen <ligenlive@gmail.com>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH] read: Fix overflow in grub_getline(),
Daniel Kiper <=