[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Drop gnulib fix-base64.patch

From: Robbie Harwood
Subject: Re: [PATCH] Drop gnulib fix-base64.patch
Date: Tue, 23 Nov 2021 11:08:55 -0500

Daniel Axtens <> writes:

> Robbie Harwood <> writes:
>> +/* For gnulib's base64 code. */
>> +#define _GL_ATTRIBUTE_CONST /* empty */
> Do we support any compiler so old or configuration so weird that we
> can't simply use 'const' here?

Unfortunately it's not quite that simple.  _GL_ATTRIBUTE_CONST actually
gates turning on `__attribute ((__const__))`, which if memory serves is
a GCC extension.  I don't know what the support matrix on grub is, but
based on the original patch there was a need to support non-gcc-likes.
Would be fine with changing that, though.

(Personally, I think it should be obvious to a reasonable compiler that
isbase64() is purely arithmetic.  However, gnulib upstream did not like
my proposal to drop the attribute marker, so we're stuck with it.)

Be well,

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]