[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] autogen.sh: Detect python
From: |
Daniel Kiper |
Subject: |
Re: [PATCH v2 2/2] autogen.sh: Detect python |
Date: |
Tue, 31 Aug 2021 20:13:13 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Mon, Aug 30, 2021 at 11:53:17AM +0200, Petr Vorel wrote:
> It help to avoid error on distros which has only python3 binary:
> ./autogen.sh: line 20: python: command not found
>
> Use python3 as the default as python2 is EOL since Jan 2020, but check
> also python which is on most distros if not all python2 because
> code still works on python2.
>
> Although it should not be needed keep the possibility to define PYTHON.
>
> For detection use "command -v" which is POSIX [3] and supported on all
> common shells (bash, zsh, dash, busybox sh, mksh) instead requiring
> "which" as extra dependency (usable on containers).
>
> Update INSTALL.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
I think you missed some minor requests from previous review. I can fix
them before committing. Anyway, Reviewed-by: Daniel Kiper
<daniel.kiper@oracle.com>
for both patches...
Thank you for fixing these issues.
Daniel