grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/2] configure: Remove obsoleted -malign-{jumps,loops,func


From: Daniel Kiper
Subject: Re: [PATCH v3 1/2] configure: Remove obsoleted -malign-{jumps,loops,functions}
Date: Thu, 26 Aug 2021 19:27:25 +0200
User-agent: NeoMutt/20170113 (1.7.2)

On Thu, Aug 26, 2021 at 09:02:31AM -0700, Fangrui Song wrote:
> GCC warns `cc1: warning: ‘-malign-loops’ is obsolete, use ‘-falign-loops’`.
> Clang silently ignores -malign-{jumps,loops,functions}.
>
> The preferred -falign-* forms have been supported since GCC 3.2, so just
> remove -malign-{jumps,loops,functions}.
>
> Acked-by: Paul Menzel <pmenzel@molgen.mpg.de>
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> Signed-off-by: Fangrui Song <maskray@google.com>

This should be in the following order:

  Signed-off-by: Fangrui Song <maskray@google.com>
  Acked-by: Paul Menzel <pmenzel@molgen.mpg.de>
  Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

I will fix this before commiting. Otherwise LGTM.

Thank you for making this patches.

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]